Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fix endless sequential pagination #494

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

ramsayleung
Copy link
Owner

@ramsayleung ramsayleung commented Sep 13, 2024

Description

Fix endless sequential pagination issue caused by invalid data return from the Spotify server side.

Motivation and Context

The log dive and conclusion are posted in #492, check that issue for detail.

Dependencies

None

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

  1. All existing tests passed
  2. Test with the example code posted in Sequential Pagination of artist albums never terminates #492, the output becomes:
Items (blocking):
* Anomaly
* Not All The Beautiful Things
* Divide & Conquer (Remixes)
* Divide & Conquer

The pagination ends as expected.

Is this change properly documented?

Yes

Don't forget to add an entry to the CHANGELOG if necessary (new features, breaking changes, relevant internal improvements).

@ramsayleung ramsayleung changed the title [fix] Check both next page and items to avoid endless sequential pagination [fix] Fix endless sequential pagination Sep 13, 2024
@ramsayleung ramsayleung merged commit 07dc031 into master Sep 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant